My RetryAnalyzer retries forever (since 6.8.15)

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

My RetryAnalyzer retries forever (since 6.8.15)

JackC
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Jorge Enrique Pombar
I ran into the same problem. In my experiments it works if you set the maxRetry count to 1, in that case it retries only once as expected. If you set it to 2 or more then it goes into that loop where it retries forever

On Monday, February 9, 2015 at 1:17:57 AM UTC-8, JackC wrote:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" target="_blank" rel="nofollow" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Krishnan Mahadevan
I have attempted at fixing this problem.

The pull request for the same : https://github.com/cbeust/testng/pull/606

Cedric,
Can you please help get this merged ? I have run the build and I have all the tests passing.




Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/
My Technical Scribbings @ http://rationaleemotions.wordpress.com/

On Thu, Feb 12, 2015 at 12:53 PM, Jorge Enrique Pombar <[hidden email]> wrote:
I ran into the same problem. In my experiments it works if you set the maxRetry count to 1, in that case it retries only once as expected. If you set it to 2 or more then it goes into that loop where it retries forever


On Monday, February 9, 2015 at 1:17:57 AM UTC-8, JackC wrote:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Cédric Beust ♔-2
Done. Do you mind adding a line to the CHANGES file to describe this change?

Thanks!


-- 
Cédric


On Fri, Feb 13, 2015 at 6:22 AM, Krishnan Mahadevan <[hidden email]> wrote:
I have attempted at fixing this problem.

The pull request for the same : https://github.com/cbeust/testng/pull/606

Cedric,
Can you please help get this merged ? I have run the build and I have all the tests passing.




Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/
My Technical Scribbings @ http://rationaleemotions.wordpress.com/

On Thu, Feb 12, 2015 at 12:53 PM, Jorge Enrique Pombar <[hidden email]> wrote:
I ran into the same problem. In my experiments it works if you set the maxRetry count to 1, in that case it retries only once as expected. If you set it to 2 or more then it goes into that loop where it retries forever


On Monday, February 9, 2015 at 1:17:57 AM UTC-8, JackC wrote:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.


--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Vitor Machado
In reply to this post by JackC
Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" target="_blank" rel="nofollow" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Krishnan Mahadevan
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/
My Technical Scribbings @ http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" target="_blank" rel="nofollow" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Vitor Machado
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" target="_blank" rel="nofollow" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" target="_blank" rel="nofollow" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="v_yOcCLug2YJ" rel="nofollow" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">vitor....@...>
Reply-To: <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="v_yOcCLug2YJ" rel="nofollow" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">testng...@...>
Date: Wednesday, 4 March 2015 8:50 pm
To: <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="v_yOcCLug2YJ" rel="nofollow" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">testng...@...>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="v_yOcCLug2YJ" rel="nofollow" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">testng-users...@googlegroups.com.
To post to this group, send email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="v_yOcCLug2YJ" rel="nofollow" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">testng...@....
Visit this group at <a href="http://groups.google.com/group/testng-users" target="_blank" rel="nofollow" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

TestProj.zip (1M) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Dinesh Srinivasan-2
The test attached runs 3 times for me ( retries for 2 times ).

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Dinesh Srinivasan-2
In reply to this post by Vitor Machado
The test attached runs 3 times for me ( retries for 2 times ). 

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Dinesh Srinivasan-2
In reply to this post by Vitor Machado
The test attached runs 3 times for me ( retries for 2 times ). 

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

On Wednesday, March 11, 2015 at 9:16:52 PM UTC+5:30, Vitor Machado wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>
Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Krishnan Mahadevan
In reply to this post by Vitor Machado
Vitor,

I am able to recreate the problem using your sample. So I decided to do some research around this.

When I looked at the commit history : https://github.com/cbeust/testng/commits/master

I noticed that the fix that I put in was merged after 6.8.21 was released.

This is the commit history for 6.8.21 tag : https://github.com/cbeust/testng/commits/testng-6.8.21 

So I guess you would need to wait till the next version of TestNG comes out for you to avail the fix.


Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/
My Technical Scribbings @ http://rationaleemotions.wordpress.com/

On Wed, Mar 11, 2015 at 9:16 PM, Vitor Machado <[hidden email]> wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Technical Scribbings @ http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>

Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Vitor Machado
I see, thank you!

Em quinta-feira, 12 de março de 2015 06:45:24 UTC-3, Krishnan escreveu:
Vitor,

I am able to recreate the problem using your sample. So I decided to do some research around this.

When I looked at the commit history : <a href="https://github.com/cbeust/testng/commits/master" target="_blank" rel="nofollow" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fcommits%2Fmaster\46sa\75D\46sntz\0751\46usg\75AFQjCNFWffzihyKdrH9Ifwe-MIAqvya5jw';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fcommits%2Fmaster\46sa\75D\46sntz\0751\46usg\75AFQjCNFWffzihyKdrH9Ifwe-MIAqvya5jw';return true;">https://github.com/cbeust/testng/commits/master

I noticed that the fix that I put in was merged after 6.8.21 was released.

This is the commit history for 6.8.21 tag : <a href="https://github.com/cbeust/testng/commits/testng-6.8.21" target="_blank" rel="nofollow" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fcommits%2Ftestng-6.8.21\46sa\75D\46sntz\0751\46usg\75AFQjCNGF2j5Wzq1OL4XYApDWJBRoNrwGpQ';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fcommits%2Ftestng-6.8.21\46sa\75D\46sntz\0751\46usg\75AFQjCNGF2j5Wzq1OL4XYApDWJBRoNrwGpQ';return true;">https://github.com/cbeust/testng/commits/testng-6.8.21 

So I guess you would need to wait till the next version of TestNG comes out for you to avail the fix.


Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" target="_blank" rel="nofollow" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" target="_blank" rel="nofollow" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

On Wed, Mar 11, 2015 at 9:16 PM, Vitor Machado <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="Wl5aIgkrTsUJ" rel="nofollow" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">vitor....@...> wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>

Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="Wl5aIgkrTsUJ" rel="nofollow" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">testng-users...@googlegroups.com.
To post to this group, send email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="Wl5aIgkrTsUJ" rel="nofollow" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">testng...@....
Visit this group at <a href="http://groups.google.com/group/testng-users" target="_blank" rel="nofollow" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: My RetryAnalyzer retries forever (since 6.8.15)

Ajith V L
Does anyone know when the next version would come out? I am using this feature and i cant switch to previous version because i am seeing a null pointer exception there.

On Thursday, March 12, 2015 at 12:16:35 PM UTC, Vitor Machado wrote:
I see, thank you!

Em quinta-feira, 12 de março de 2015 06:45:24 UTC-3, Krishnan escreveu:
Vitor,

I am able to recreate the problem using your sample. So I decided to do some research around this.

When I looked at the commit history : <a href="https://github.com/cbeust/testng/commits/master" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fcommits%2Fmaster\46sa\75D\46sntz\0751\46usg\75AFQjCNFWffzihyKdrH9Ifwe-MIAqvya5jw';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fcommits%2Fmaster\46sa\75D\46sntz\0751\46usg\75AFQjCNFWffzihyKdrH9Ifwe-MIAqvya5jw';return true;">https://github.com/cbeust/testng/commits/master

I noticed that the fix that I put in was merged after 6.8.21 was released.

This is the commit history for 6.8.21 tag : <a href="https://github.com/cbeust/testng/commits/testng-6.8.21" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fcommits%2Ftestng-6.8.21\46sa\75D\46sntz\0751\46usg\75AFQjCNGF2j5Wzq1OL4XYApDWJBRoNrwGpQ';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fcommits%2Ftestng-6.8.21\46sa\75D\46sntz\0751\46usg\75AFQjCNGF2j5Wzq1OL4XYApDWJBRoNrwGpQ';return true;">https://github.com/cbeust/testng/commits/testng-6.8.21 

So I guess you would need to wait till the next version of TestNG comes out for you to avail the fix.


Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

On Wed, Mar 11, 2015 at 9:16 PM, Vitor Machado <[hidden email]> wrote:
Here's a simple eclipse project (with an Ant buildfile included) to run the bug scenario.

Em sábado, 7 de março de 2015 02:18:20 UTC-3, Krishnan escreveu:
Vitor,
Do you have a sample test that you would like to share with us, which I can use to recreate the problem in TestNG 6.8.21 ?

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ <a href="http://wakened-cognition.blogspot.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Fwakened-cognition.blogspot.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNHzOdYJCASIDF_28vQtkp9gnKAYSQ';return true;">http://wakened-cognition.blogspot.com/
My Technical Scribbings @ <a href="http://rationaleemotions.wordpress.com/" rel="nofollow" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Frationaleemotions.wordpress.com%2F\46sa\75D\46sntz\0751\46usg\75AFQjCNEcBOKyRn0lpL8LDbBuyAlKdwgXwQ';return true;">http://rationaleemotions.wordpress.com/

From: Vitor Machado <[hidden email]>
Reply-To: <[hidden email]>
Date: Wednesday, 4 March 2015 8:50 pm
To: <[hidden email]>

Subject: [testng-users] Re: My RetryAnalyzer retries forever (since 6.8.15)

Still happening to me as of 6.8.21. Reverting to 6.8.14 fixed the problem.

Em segunda-feira, 9 de fevereiro de 2015 07:17:57 UTC-2, JackC escreveu:
Unfortunately i haven't had time to investigate thoroughly but my simple IRetryAnalyzer implementation now retries forever from this version to current (6.8.14 works fine). I suspect it might have something to do with <a href="https://github.com/cbeust/testng/pull/572" rel="nofollow" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcbeust%2Ftestng%2Fpull%2F572\46sa\75D\46sntz\0751\46usg\75AFQjCNGB_v91UwXzhxXgE8Cu3xN-qG9Cog';return true;">https://github.com/cbeust/testng/pull/572. I tried to look through the code but its a little cryptic to fresh eyes.

I haven't spotted any other comments of anyone else seeing this so i thought i would post here to see if this is common knowledge.

Cheers

My basic retry analyzer:

public class RetryAnalyzer implements IRetryAnalyzer {
    private int retryCount = 0;
    private int maxRetryCount;
    private static int maxRetryCountInitializer = 2;

    public static void setMaxRetryCountInitializer(int maxRetryCount) {
        RetryAnalyzer.maxRetryCountInitializer = maxRetryCount;
    }

    public RetryAnalyzer() {
        this.retryCount = 0;
        this.maxRetryCount = maxRetryCountInitializer;
    }

    @Override
    public boolean retry(ITestResult result) {
        if (hasRetriesRemaining()) {
            retryCount++;
            return true;
        }

        return false;
    }

    private boolean hasRetriesRemaining() {
        return (retryCount < this.maxRetryCount);
    }
}

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to [hidden email].
Visit this group at <a href="http://groups.google.com/group/testng-users" rel="nofollow" target="_blank" onmousedown="this.href='http://groups.google.com/group/testng-users';return true;" onclick="this.href='http://groups.google.com/group/testng-users';return true;">http://groups.google.com/group/testng-users.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/optout';return true;" onclick="this.href='https://groups.google.com/d/optout';return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at http://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.